Date: Fri, 16 Aug 2013 13:41:31 -0400 From: Mark Johnston <markj@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys Message-ID: <20130816174131.GB1888@charmander.sandvine.com> In-Reply-To: <CACYV=-G74u3UODYg=_==Mup20zXFvXnbTjoQ5Rn2oMGm%2BPuTmQ@mail.gmail.com> References: <201308140042.r7E0gMtf054550@svn.freebsd.org> <201308140819.13854.jhb@freebsd.org> <20130816170027.GA1888@charmander.sandvine.com> <CACYV=-G74u3UODYg=_==Mup20zXFvXnbTjoQ5Rn2oMGm%2BPuTmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 16, 2013 at 07:13:16PM +0200, Davide Italiano wrote: > [trim old mails] > > > diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h > > index e3e18a6..90585de 100644 > > --- a/sys/sys/pmckern.h > > +++ b/sys/sys/pmckern.h > > @@ -51,13 +51,11 @@ > > #define PMC_FN_CSW_IN 2 > > #define PMC_FN_CSW_OUT 3 > > #define PMC_FN_DO_SAMPLES 4 > > -#define PMC_FN_KLD_LOAD 5 > > -#define PMC_FN_KLD_UNLOAD 6 > > -#define PMC_FN_MMAP 7 > > -#define PMC_FN_MUNMAP 8 > > -#define PMC_FN_USER_CALLCHAIN 9 > > -#define PMC_FN_USER_CALLCHAIN_SOFT 10 > > -#define PMC_FN_SOFT_SAMPLING 11 > > +#define PMC_FN_MMAP 5 > > +#define PMC_FN_MUNMAP 6 > > +#define PMC_FN_USER_CALLCHAIN 7 > > +#define PMC_FN_USER_CALLCHAIN_SOFT 8 > > +#define PMC_FN_SOFT_SAMPLING 9 > > > > I've skimmed over your patch quickly so I could miss something, but I > worry about this change breaking the KBI. > Does this make sense for you? I think you're right. I considered this last night, but it didn't occur to me that external modules might try to invoke these hooks. I'm not sure if such modules exist, but it's better to be safe. I updated the patch here: http://people.freebsd.org/~markj/patches/hwpmc-eh/hwpmc-eh-3.diff Thanks! -Mark
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130816174131.GB1888>