Date: Sat, 1 Aug 2015 16:40:32 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Pedro Giffuni <pfg@freebsd.org> Cc: Bruce Evans <brde@optusnet.com.au>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286102 - head/usr.bin/wall Message-ID: <20150801163923.J1074@besplex.bde.org> In-Reply-To: <55BB9E9C.9030608@FreeBSD.org> References: <201507310112.t6V1CWh8034232@repo.freebsd.org> <20150731162408.M1843@besplex.bde.org> <55BB9E9C.9030608@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 Jul 2015, Pedro Giffuni wrote: > On 07/31/15 02:12, Bruce Evans wrote: >> On Fri, 31 Jul 2015, Pedro F. Giffuni wrote: >> > ... > >>> static char errbuf[1024]; >> >> Another static buffer. The function is obviously not reentrant. This >> large static buffer mainly wastes space all the time instead of only >> when the function is called. > > But if I drop that static I get a bunch of errors: Yes. I forgot that it is is returned. Older not so good APIs often return a pointer to static data. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150801163923.J1074>