Date: Thu, 26 Aug 2004 21:38:57 -0700 From: Kris Kennaway <kris@obsecurity.org> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gettext Makefile Message-ID: <20040827043857.GA16903@xor.obsecurity.org> In-Reply-To: <200408270116.i7R1GmiF036802@repoman.freebsd.org> References: <200408270116.i7R1GmiF036802@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Aug 27, 2004 at 01:16:48AM +0000, David E. O'Brien wrote: > obrien 2004-08-27 01:16:48 UTC > > FreeBSD ports repository > > Modified files: > devel/gettext Makefile > Log: > Add a NO_GETTEXT_OPTIONS knob. Several points: 1) You also silently removed the dependency on expat. 2) User control knobs of this nature must be in the WITH_*/WITHOUT_* namespace, not NO_*. 3) This duplicates what BATCH does, as we discussed about a month ago. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQFBLrrhWry0BWjoQKURApaBAJ9N3iN5IfmNxO/JicqMvlL0dGrDqgCeJ9Pv Flr0dBeYFXgoxPXgKTEmwPQ= =p6lI -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040827043857.GA16903>