Date: Mon, 03 Mar 1997 02:58:56 -0700 From: Warner Losh <imp@village.org> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/ping ping.c Message-ID: <E0w1UWG-0006aO-00@rover.village.org> In-Reply-To: Your message of "Mon, 03 Mar 1997 01:44:20 PST." <199703030944.BAA17164@freefall.freebsd.org> References: <199703030944.BAA17164@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199703030944.BAA17164@freefall.freebsd.org> Warner Losh writes: : imp 97/03/03 01:44:20 : : Modified: sbin/ping ping.c : Log: : Backport changes from current: : 1) getopt returnes -1 and remove 'h:' that isn't needed : 2) -l needs super user now to work : 3) check to make sure that address returned from gethostbyname will fit in : sin_addr : 4) Fix minor strncpy bug. : 5) Don't leak information about ICMP packets that aren't for you, unless : superuser. : : Revision Changes Path : 1.8.2.8 +12 -3 src/sbin/ping/ping.c Unless there are problems found with this, I'd like to merge it into the 2.1 branch. At least those parts that drop in easily, I'm not sure about #5. Also, the 2.1 branch should have other changes merged as well (specifically the setuid(getuid()) change and some of the -Q chanage that #5 depends on). Can anybody (besides Guido who is already look at it) review this? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E0w1UWG-0006aO-00>