Date: Wed, 06 Jun 2001 20:01:46 -0700 From: Peter Wemm <peter@wemm.org> To: Richard Todd <rmtodd@ichotolot.servalan.com> Cc: current@freebsd.org Subject: Re: recent change to ata-disk.c seems to be horked... Message-ID: <20010607030146.B4B09380A@overcee.netplex.com.au> In-Reply-To: <m157no5-004MgFC@servalan.servalan.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Bah, what a brilliant end to an already bad day. :-( I managed to commit a
patch that I changed last night, and when recompiling today before commit,
I used the wrong tree. I was in a rush to get home for my son's grade 1
class school musical.
Yes, it cannot possibly work. :-( Fixing it now.. Argh!
Richard Todd wrote:
> Just tried to build a kernel with freshly-supped sources and got:
>
> cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extens
ions -ansi -g -nostdinc -I- -I. -I../.. -I../../dev -I../../../include -I.
./../contrib/dev/acpica -D_KERNEL -include opt_global.h -elf -mpreferred-
stack-boundary=2 ../../dev/ata/ata-disk.c
> ../../dev/ata/ata-disk.c:88: syntax error before `&'
> ../../dev/ata/ata-disk.c:55: warning: `adopen' used but never defined
> ../../dev/ata/ata-disk.c:56: warning: `adstrategy' used but never defined
> ../../dev/ata/ata-disk.c:57: warning: `addump' used but never defined
> ../../dev/ata/ata-disk.c:58: warning: `ad_cdevsw' defined but not used
> ../../dev/ata/ata-disk.c:73: warning: `addisk_cdevsw' defined but not used
> ../../dev/ata/ata-disk.c:76: warning: `ad_invalidatequeue' declared `static'
but never defined
> ../../dev/ata/ata-disk.c:77: warning: `ad_tagsupported' declared `static' but
never defined
> ../../dev/ata/ata-disk.c:78: warning: `ad_timeout' declared `static' but neve
r defined
> ../../dev/ata/ata-disk.c:79: warning: `ad_free' declared `static' but never d
efined
> ../../dev/ata/ata-disk.c:80: warning: `ad_version' declared `static' but neve
r defined
> ../../dev/ata/ata-disk.c:83: warning: `adp_lun_map' defined but not used
> ../../dev/ata/ata-disk.c:85: warning: `ata_dma' defined but not used
> ../../dev/ata/ata-disk.c:86: warning: `ata_wc' defined but not used
> ../../dev/ata/ata-disk.c:87: warning: `ata_tags' defined but not used
> *** Error code 1
>
> Stop in /usr/src/sys/compile/ICHOTOLOTSMP.
>
> Line 88 is in the diffs that peter just recently committed (rev 1.106; see
> the commitlogs/sys entry for 2001/06/06 15:17:09 PDT). The offending line
> is
> TUNABLE_INT("hw.ata.ata_dma", &ata_dma);
>
> Looking at the definition of TUNABLE_INT, it doesn't look like it'd take well
> to having the 2nd argument (var) be something beginning with &, given that th
e
> first thing the definition does is try to define a function based on the var
> given, in this case
> static void __Tunable_&ata_dma (void *ignored)
>
> See the problem?
>
>
>
>
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010607030146.B4B09380A>