Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Dec 2004 01:49:15 GMT
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 66650 for review
Message-ID:  <200412080149.iB81nFd2024498@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://perforce.freebsd.org/chv.cgi?CH=66650

Change 66650 by sam@sam_ebb on 2004/12/08 01:48:31

	correct comparison order during ap selection

Affected files ...

.. //depot/projects/wifi/sys/net80211/ieee80211_node.c#25 edit

Differences ...

==== //depot/projects/wifi/sys/net80211/ieee80211_node.c#25 (text+ko) ====

@@ -551,7 +551,7 @@
 	rssia = ic->ic_node_getrssi(a);
 	rssib = ic->ic_node_getrssi(b);
 	if (maxa != maxb && abs(rssib - rssia) < 5)
-		return maxb - maxa;
+		return maxa - maxb;
 
 	/* XXX use freq for channel preference */
 	/* for now just prefer 5Ghz band to all other bands */
@@ -563,7 +563,7 @@
 		return -1;
 
 	/* all things being equal, use signal level */
-	return rssib - rssia;
+	return rssia - rssib;
 }
 
 /*
@@ -683,7 +683,7 @@
 		if (ieee80211_match_bss(ic, ni) == 0) {
 			if (selbs == NULL)
 				selbs = ni;
-			else if (ieee80211_node_compare(ic, ni, selbs) < 0) {
+			else if (ieee80211_node_compare(ic, ni, selbs) > 0) {
 				ieee80211_unref_node(&selbs);
 				selbs = ni;
 			} else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412080149.iB81nFd2024498>