Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Aug 2013 20:55:32 +0200
From:      Zbigniew Bodek <zbb@semihalf.com>
To:        Konstantin Belousov <kib@freebsd.org>
Cc:        svn-src-all@freebsd.org
Subject:   Re: svn commit: r254415 - in head/sys: dev/streams fs/devfs kern sys
Message-ID:  <CAG7dG%2Byat0eo=omyRdnYV_AR030p4DHiDvxK_Tzwgm2NrDA=iQ@mail.gmail.com>
In-Reply-To: <201308161422.r7GEMLWE006753@svn.freebsd.org>
References:  <201308161422.r7GEMLWE006753@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
2013/8/16 Konstantin Belousov <kib@freebsd.org>

> Author: kib
> Date: Fri Aug 16 14:22:20 2013
> New Revision: 254415
> URL: http://svnweb.freebsd.org/changeset/base/254415
>
> Log:
>   Restore the previous sendfile(2) behaviour on the block devices.
>   Provide valid .fo_sendfile method for several missed struct fileops.
>
>   Reviewed by:  glebius
>   Sponsored by: The FreeBSD Foundation
>
> Modified:
>   head/sys/dev/streams/streams.c
>   head/sys/fs/devfs/devfs_vnops.c
>   head/sys/kern/sys_procdesc.c
>   head/sys/kern/vfs_vnops.c
>   head/sys/sys/file.h
>
>
Hello Konstantin.

I believe that this commit adds redundant vn_sendfile declaration. Please
see below:

c1: warnings being treated as errors
sys/kern/uipc_syscalls.c:161: warning: redundant redeclaration of
'vn_sendfile' [-Wredundant-decls]
sys/sys/file.h:244: warning: previous declaration of 'vn_sendfile' was here

Best regards
Zbyszek Bodek



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG7dG%2Byat0eo=omyRdnYV_AR030p4DHiDvxK_Tzwgm2NrDA=iQ>