Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Nov 2004 12:38:11 +0300
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Hideki Yamamoto <yamamoto436@oki.com>, alfred@freebsd.org
Cc:        freebsd-stable@freebsd.org
Subject:   Re: pppoe server option
Message-ID:  <20041129093811.GB1659@cell.sick.ru>
In-Reply-To: <20041128.213540.74733833.yamamoto436@oki.com>
References:  <20041121.003425.41664309.yamamoto436@oki.com> <20041122081250.GA49670@cell.sick.ru> <20041128.213540.74733833.yamamoto436@oki.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 28, 2004 at 09:35:40PM +0900, Hideki Yamamoto wrote:
H> > -l switch configures label in ppp.conf
H> > -p swicth configures provider name which is announced in Ethernet.
H> 
H> Thank you for your reply.  
H> I think comment statement in /etc/defaults/rc.conf should be changed
H> because the current comment means '-l'.  Otherwise we should change
H> /etc/rc.network.   Don't you think so?
H> 
H> -------------- /etc/defaults/rc.conf ----------
H>  pppoed_provider="service-pppoe"	# Provider and ppp(8) config file entry.
H> -----------------------------------------------

[ccing Alfred, since cvs annotate points at him]

If label has not been specified, it defaults to provider. So this comment
is not meaningless. If you want to specify another label, you should use
pppoed_flags variable.

I think it will be better to change comment to "PPPoE Provider name".
Alfred, what do you think?

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041129093811.GB1659>