Date: Mon, 24 Sep 2001 04:19:42 -0400 (EDT) From: "Matthew N. Dodd" <winter@jurai.net> To: Jonathan Lemon <jlemon@flugsvamp.com> Cc: net@freebsd.org Subject: Re: review request. Message-ID: <Pine.BSF.4.21.0109240418460.3806-100000@sasami.jurai.net> In-Reply-To: <20010923190346.B79251@prism.flugsvamp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 23 Sep 2001, Jonathan Lemon wrote: > > Right; rather than failing the detach routines will fuss about it so you > > know exactly how you screwed up. I don't see this papering anything over. > > Because this is not a normal operational error. If anything, the > statement should be a KASSERT(), but I don't really see the need for it. bpfdetach() already has a test for this case; adding one to if_detach() doesn't seem like a bad thing so long as abusing if_index isn't a problem. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0109240418460.3806-100000>