Date: Fri, 12 Jul 2002 12:06:55 -0700 From: Jeffrey Hsu <hsu@FreeBSD.org> To: Don Lewis <dl-freebsd@catspoiler.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c Message-ID: <0GZ5004IMH36IU@mta5.snfc21.pbi.net> In-Reply-To: Message from Don Lewis <dl-freebsd@catspoiler.org> "of Fri, 12 Jul 2002 04:07:12 PDT." <200207121107.g6CB7Cwr013757@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> I've been doing some digging through the code and it looks to me like > both the INP_LOCK() and inp->inp_socket == NULL test can be eliminated. The inp lock is needed for sure. It does look like the inp->inp_socket == NULL test can be eliminated, but I didn't want to introduce any extraneous changes with the inp locking patch, so that change is left for a later round. > The inp->inp_socket == NULL check shows up in the code > listing in _TCP/IP Illustrated Volume 2_, but there doesn't seem to be > any need for it there. It probably slipped in to "fix" panic some time > in the deep dark past when there were probably locking problems in the > code. This is where the CSRG SCCS archive comes in real handy. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0GZ5004IMH36IU>