Date: Sun, 13 Jun 2010 22:35:25 +0200 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: mdf@FreeBSD.org Cc: svn-src-head@freebsd.org, Lawrence Stewart <lstewart@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: svn commit: r209119 - head/sys/sys Message-ID: <20100613203524.GA1736@mole.fafoe.narf.at> In-Reply-To: <AANLkTik2X_x6cNsLWQTNqDHuN69IZgyMnM--0vhp36xk@mail.gmail.com> References: <201006130239.o5D2du3m086332@svn.freebsd.org> <20100613101025.GD1320@garage.freebsd.pl> <AANLkTik2X_x6cNsLWQTNqDHuN69IZgyMnM--0vhp36xk@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 13, 2010 at 01:59:11PM +0000, mdf@FreeBSD.org wrote: > > (Relevant but almost a thread hijack): > > At Isilon we've run into a lot of problems with variable declarations > in macros, especially with -Wshadow turned on. We ended up > backporting __COUNTER__ from later versions of gcc and then using it > to make unique variable names. > > - is the backport (or a fresh implementation) something that could be > done within the scope of the GPL license? > - is it something FreeBSD would be interested in? > - is __COUNTER__ supported by clang? > - if not, could it be? > > -Wshadow found several nasty bugs in our code, and apart from a few > spurious warnings it has been handy to have when building our > filesystem. In my opinion using non-standard C features just to work around warnings is a bit questionable. A more useful feature would be an attribute that avoids -Wshadow warnings. Regards, Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100613203524.GA1736>