Date: Sun, 14 Mar 2021 01:15:11 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: =?utf-8?Q?T=C4=B3l_Coosemans?= <tijl@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 9097e3cbcac4 - main - Partially revert libcxxrt changes to avoid _Unwind_Exception change Message-ID: <BC83628A-A8EF-4964-BD0E-9F9738BFFF8C@FreeBSD.org> In-Reply-To: <20210313183812.77b74819@FreeBSD.org> References: <202103131354.12DDsnKR065154@gitrepo.freebsd.org> <20210313183812.77b74819@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 13 Mar 2021, at 18:38, T=C4=B3l Coosemans <tijl@FreeBSD.org> wrote: >=20 > On Sat, 13 Mar 2021 13:54:49 GMT Dimitry Andric <dim@FreeBSD.org> = wrote: >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9097e3cbcac455eb0dedd097d8d5548c= 72568d0a >>=20 >> commit 9097e3cbcac455eb0dedd097d8d5548c72568d0a >> Author: Dimitry Andric <dim@FreeBSD.org> >> AuthorDate: 2021-03-13 13:54:24 +0000 >> Commit: Dimitry Andric <dim@FreeBSD.org> >> CommitDate: 2021-03-13 13:54:24 +0000 >>=20 >> Partially revert libcxxrt changes to avoid _Unwind_Exception = change ... >> --- a/contrib/libcxxrt/unwind-itanium.h >> +++ b/contrib/libcxxrt/unwind-itanium.h >> @@ -79,12 +79,9 @@ struct _Unwind_Exception >> { >> uint64_t exception_class; >> _Unwind_Exception_Cleanup_Fn exception_cleanup; >> - uintptr_t private_1; >> - uintptr_t private_2; >> -#if __SIZEOF_POINTER__ =3D=3D 4 >> - uint32_t reserved[3]; >> -#endif >> - } __attribute__((__aligned__)); >> + unsigned long private_1; >> + unsigned long private_2; >> + } ; >=20 > Shouldn't these definitions be the same as the ones in GCC? If you want to keep the ABI compatible with what it was, no. Otherwise, = you could consider it. But for what gain? -Dimitry --Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYE1VjwAKCRCwXqMKLiCW oxCsAKDfhglHmT2HK4yRHyDVK+2BULydnACfZDbJyxWu/MG/O2RUPa0VNoRBhKo= =jJXN -----END PGP SIGNATURE----- --Apple-Mail=_A3542C0C-E7BF-4613-9BA6-36B2CE593D92--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BC83628A-A8EF-4964-BD0E-9F9738BFFF8C>