Date: Tue, 17 Mar 2009 14:41:54 +0000 (UTC) From: Bruce M Simpson <bms@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet igmp.c in.c in_mcast.c Message-ID: <200903171442.n2HEg99c049229@repoman.freebsd.org>
index | next in thread | raw e-mail
bms 2009-03-17 14:41:54 UTC
FreeBSD src repository
Modified files:
sys/netinet igmp.c in.c in_mcast.c
Log:
SVN rev 189931 on 2009-03-17 14:41:54Z by bms
Deal with the case where ifma_protospec may be NULL, during
any IPv4 multicast operations which reference it.
There is a potential race because ifma_protospec is set to NULL
when we discover the underlying ifnet has gone away. This write
is not covered by the IF_ADDR_LOCK, and it's difficult to widen
its scope without making it a recursive lock. It isn't clear why
this manifests more quickly with 802.11 interfaces, but does not
seem to manifest at all with wired interfaces.
With this change, the 802.11 related panics reported by sam@
and cokane@ should go away. It is not the right fix, that requires
more thought before 8.0.
Idea from: sam
Tested by: cokane
Revision Changes Path
1.64 +20 -5 src/sys/netinet/igmp.c
1.124 +8 -1 src/sys/netinet/in.c
1.18 +9 -0 src/sys/netinet/in_mcast.c
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903171442.n2HEg99c049229>