Date: Sun, 19 Oct 1997 20:40:18 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: freebsd-hackers@FreeBSD.ORG Cc: proff@iq.org (Julian Assange) Subject: Re: nasty problem with vnode and other disk drivers? Message-ID: <19971019204018.PF25731@uriah.heep.sax.de> In-Reply-To: <19971019170838.1109.qmail@iq.org>; from Julian Assange on Oct 19, 1997 17:08:38 -0000 References: <19971019170838.1109.qmail@iq.org>
next in thread | previous in thread | raw e-mail | index | archive | help
As Julian Assange wrote: > physio() is passed a uio argument, with an offset into the device. > It then builds a struct buf, and calculates b_blkno like so: > > bp->b_blkno = btodb(uio->uio_offset); > > (btodb just divides by 512) (and so on) All this nasty shiftomania is subject to be killed some day, for b_blkno should be replaced by a b_offset field (of type off_t). I think a number of (not so unimportant to the project effort :) people already agreed that this is the way to go, so it's only a matter of time, until someone can spend the energy required to make this change, and debug everything. Hopefully, this should still be before 3.0 hits the surface. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19971019204018.PF25731>