Date: Tue, 6 Oct 2015 16:16:33 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Warner Losh <imp@FreeBSD.org>, <src-committers@FreeBSD.org>, <svn-src-all@FreeBSD.org>, <svn-src-head@FreeBSD.org>, <sjg@juniper.net> Subject: Re: svn commit: r288911 - head/share/mk Message-ID: <23330.1444173393@chaos> In-Reply-To: <56143BB6.1010700@FreeBSD.org> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <15356.1444161040@chaos> <5614286D.7020904@FreeBSD.org> <18968.1444166223@chaos> <56143BB6.1010700@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > Are you refering to a src/share/mk which is sibling to src/ports/* or > > something else? > > > > Because with MAKESYSPATH=.../share/mk src/share/mk/sys.mk is what you > > should find. > > Right. That's what I'm referring to and what I prefer. Ok good. > If we update our checked in share/mk/custom.sys.env.mk file, we want all > builds to get it before having to install it to /usr/share/mk. We for a > period were using a script to wrap make to setup the environment before > we realized sys.mk was already capable of doing this. Being able to bind > a build to a specific environment is important, vs using the environment > installed from the last build or a foreign /usr/share/mk (FreeBSD's files). Sure, we use a wrapper script as it keeps life simple. > > But there's no reason you cannot make exceptions - by (as I think you > > already mentioned) adding a check for $SRCTOP/ports in local*sys*mk > > to suppress src.conf at least. > > > > Yes that has been my local fix for now. Ok - FWIW I don't see any particular problem with that. > Perhaps my fix should get checked in so no one else is surprised by > src.conf, and all of the tweaks its options set, coming in. Not sure I'd go that far. You could perhaps add a comment to src.conf for anyone who's frustrated?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?23330.1444173393>