Date: Thu, 9 Jul 2015 20:45:22 -0600 From: Warner Losh <imp@bsdimp.com> To: George Neville-Neil <gnn@freebsd.org> Cc: Peter Wemm <peter@wemm.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285336 - in head/sys: netipsec opencrypto Message-ID: <E599DA16-96AC-47BF-8157-25A0AFDF10C4@bsdimp.com> In-Reply-To: <E82240DD-05F4-4CAD-B478-FF0948816FF0@freebsd.org> References: <201507091816.t69IGawf097288@repo.freebsd.org> <15342729.MI2b1tqqeb@overcee.wemm.org> <E82240DD-05F4-4CAD-B478-FF0948816FF0@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jul 9, 2015, at 8:27 PM, George Neville-Neil <gnn@freebsd.org> = wrote: >=20 >=20 >=20 > On 9 Jul 2015, at 18:26, Peter Wemm wrote: >=20 >> On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: >>> Author: gnn >>> Date: Thu Jul 9 18:16:35 2015 >>> New Revision: 285336 >>> URL: https://svnweb.freebsd.org/changeset/base/285336 >>>=20 >>> Log: >>> Add support for AES modes to IPSec. These modes work both in = software >>> only mode and with hardware support on systems that have AESNI >>> instructions. >>>=20 >>> Differential Revision: D2936 >>> Reviewed by: jmg, eri, cognet >>> Sponsored by: Rubicon Communications (Netgate) >>>=20 >>> Modified: >>> head/sys/netipsec/xform_ah.c >>> head/sys/netipsec/xform_esp.c >>=20 >>> @@ -953,6 +989,11 @@ esp_output_cb(struct cryptop *crp) >>> case CRYPTO_SHA2_512_HMAC: >>> alen =3D esph->hashsize/2; >>> break; >>> + case CRYPTO_AES_128_GMAC: >>> + case CRYPTO_AES_192_GMAC: >>> + case CRYPTO_AES_256_GMAC: >>> + alen =3D esph->hashsize; >>> + break; >>> default: >>> alen =3D AH_HMAC_HASHLEN; >>> break; >>=20 >> This introduces a LINT compile failure: >>=20 >> /usr/src/sys/netipsec/xform_esp.c:992:9: error: use of undeclared = identifier >> 'CRYPTO_AES_128_GMAC' >> case CRYPTO_AES_128_GMAC: >> ^ >> /usr/src/sys/netipsec/xform_esp.c:993:9: error: use of undeclared = identifier >> 'CRYPTO_AES_192_GMAC' >> case CRYPTO_AES_192_GMAC: >> ^ >> /usr/src/sys/netipsec/xform_esp.c:994:9: error: use of undeclared = identifier >> 'CRYPTO_AES_256_GMAC' >> case CRYPTO_AES_256_GMAC: >> ^ >> 3 errors generated. >> --- xform_esp.o --- >>=20 >=20 > Apologies, fixed in 285347. BTW The LINT conf in amd64 is ignored. = Why? What do you mean? Warner --Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVnzHCAAoJEGwc0Sh9sBEA7xsP/0RZHvusodBpr9ox2/qGOSBR Qi7Iha63+SuHqbfcU0ArO9GW31UggEqiDYUSMhek5cbT8WrdS08OAW4sCZzZIMoE GvyWzH9uzhq64OVDQG5OO8fPlQdq04EpjfBh+1xvcILJF8fky1DxamvUuI9mQJ99 QSssSODRrgxhNO3V2GgndzT8N7L/7r/Pt/k6/FqV2Klsd0gKT7+K2stwW9WcvzFx 2V5d0PgT0uXqKz0zKhMeGN7fhy6562uCSlxi+Ph32/BAJ3qgHZAOp/W3IZXuNlQP LtvEDDcnp4uEqjMu6sEC4xdUpqKUWnG1dNUjDmsoznY5eO5BPbjXi2cGjr391ceg 1gMyWzzzbMIyQ47KQHMi2hri4Ri+oECB8/FfrcfJmRffaow7+O5HOADG6biuDCfH Nd/kjcGi6OM0o7W0W3sK3jwBZpfW6esFKfW+aro94aBXStXxEgUS9EXKQYRbtKU9 WaG2paGamczKp6tefvUhnA+OaFNTjFEmYeO5X2WZhglm+2PY7YID7gdDWR5JZsBU EXdtJbBVTYB13esu4vHw5XyfUQrrMh2tynMbH80BXtexV3cCDVwbQ6oG7tacmGxk eNcj4aS6XJc/GON6pLh1s/HRPnWNmPcXt/Ks8+YL0U6yMeqhLwVvKe/8ITH83TrB 1qPwO1kyd0Qbww5dKhVC =P1pG -----END PGP SIGNATURE----- --Apple-Mail=_072917BF-D448-46F0-9753-F031D8F38D96--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E599DA16-96AC-47BF-8157-25A0AFDF10C4>