Date: Sat, 4 Aug 2018 15:54:30 -0700 From: Conrad Meyer <cem@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337165 - head/sys/fs/fuse Message-ID: <CAG6CVpURd_V7T%2BgCB_gTmx1Q-3p1rhqy7YFDLY9eSH89%2BSE=sA@mail.gmail.com> In-Reply-To: <CANCZdfp14_geVtU3M=s=bs%2BYaKaUAmxJKKkBnA4o3CLLoeYmQg@mail.gmail.com> References: <201808021925.w72JPhIu086582@repo.freebsd.org> <CANCZdfp14_geVtU3M=s=bs%2BYaKaUAmxJKKkBnA4o3CLLoeYmQg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 4, 2018 at 3:46 PM, Warner Losh <imp@bsdimp.com> wrote: > On Thu, Aug 2, 2018 at 1:25 PM, Conrad Meyer <cem@freebsd.org> wrote: >> >> Author: cem >> Date: Thu Aug 2 19:25:43 2018 >> New Revision: 337165 >> URL: https://svnweb.freebsd.org/changeset/base/337165 >> >> Log: >> FUSE: Bump maximum IO size to enable more performant operation >>... >> - mp->mnt_stat.f_iosize = PAGE_SIZE; >> + mp->mnt_stat.f_iosize = DFLTPHYS; > > Why DFLTPHYS instead of MAXPHYS? > > DFLTPHYS defaults to 64k, while MAXPHYS is 128k. It was chosen arbitrarily. Either is a big improvement over 4k. According to the bug reporter, 64k is a common choice in other implementations. But I have no objection to MAXPHYS. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpURd_V7T%2BgCB_gTmx1Q-3p1rhqy7YFDLY9eSH89%2BSE=sA>