Date: Thu, 6 Nov 1997 06:37:39 +0100 (MET) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: kushnir@ap3.gluk.apc.org (Vladimir Kushnir) Cc: freebsd-current@FreeBSD.ORG Subject: Re: attach_mss for full duplex: possible misspelling? Message-ID: <199711060537.GAA24505@labinfo.iet.unipi.it> In-Reply-To: <Pine.LNX.3.95.971106022311.9509A-100000@ap3.gluk.apc.org> from "Vladimir Kushnir" at Nov 6, 97 02:24:02 am
next in thread | previous in thread | raw e-mail | index | archive | help
> Sorry, perhaps I'm just plainly stupid but isn't there a misspelling in an
> attach_mss routine (new sound driver, sound/ad1848.c, lines 1724-1725)? It
> calls ad1848_init like
>
> ad1848_init("MS Sound System0", hw_config->io_base + 4,
> hw_config->irq,
> hw_config->dma,
> hw_config->dma, 0, hw_config->osp);
> }
>
> (with both dma equal). Should not it spell
> ...
> hw_config->dma,
> hw_config->dma2,
> ... instead? At least, this way it initializes my card (CS4231 based
> Yamaha OPL3 PnP duplex card) correctly.
of course you can try, but the AD1848 and some clones have only 1 DMA
channel, and I believe the code is not enough informed to know which
card it is attaching.
BTW the Yamaha as far as I know is not based on the CS4231 -- it uses a
proprietary chip which _emulates_ some features of the CS423x but has
some differences (e.g. a master volume control using separate
registers).
Cheers
Luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711060537.GAA24505>