Date: Fri, 5 Sep 2008 10:35:37 -0300 From: "Carlos A. M. dos Santos" <unixmania@gmail.com> To: frtzkatz@yahoo.com Cc: freebsd-multimedia@freebsd.org Subject: Re: Is this a bug? (in /usr/src/sys/dev/bktr/bktr_os.c ) Message-ID: <e71790db0809050635u69bd0336j768b4efe734211a5@mail.gmail.com> In-Reply-To: <542052.24495.qm@web63007.mail.re1.yahoo.com> References: <542052.24495.qm@web63007.mail.re1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 4, 2008 at 9:59 PM, Fritz Katz <frtzkatz@yahoo.com> wrote: > In FreeBSD-7.0, /usr/src/sys/dev/bktr/bktr_os.c, line 469: > > http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70#L469 > __________ > > fail: > if (bktr->res_irq) > bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq); > if (bktr->res_mem) > bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem); > return error; > __________ > > Shouldn't the type field for the second bus_release_resource be SYS_RES_MEMORY? Would it cause a kernel panic if it were ever hit? If it is a bug, it's probably been there for years. For sure it is a bug, since it is not in accordance with http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70;im=excerpts#L347 -- cd /usr/ports/sysutils/life make clean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e71790db0809050635u69bd0336j768b4efe734211a5>