Date: Thu, 1 Dec 2005 19:27:57 +0200 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Warner Losh <imp@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20051201172757.GG20961@ip.net.ua> In-Reply-To: <200512011708.jB1H8u3Y065515@repoman.freebsd.org> References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--JbKQpFqZXJ2T76Sg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote: > imp 2005-12-01 17:08:56 UTC >=20 > FreeBSD src repository >=20 > Modified files: > . Makefile.inc1=20 > Log: > In make buildenv, spell sh as ${SHELL}. In this case, we don't want > to hard code /bin/sh since we're forking it for the user to type > commands into. As such, ${SHELL} is the preferred thing users type > commands into. > =20 > Revision Changes Path > 1.524 +1 -1 src/Makefile.inc1 >=20 Please consider backing it out. In this case, we want to hard code it to "sh" since the stock ~root/.cshrc always resets $PATH, which breaks "make buildenv" for root (which most of us use). Testcase: "which cc" =66rom under "make buildenv" shell. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --JbKQpFqZXJ2T76Sg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDjzKdqRfpzJluFF4RAsHsAJ476stTNyzjBse9tq6sKN/yL7zRWQCcC5GL rdKK8pRFB8KPlqv8o5/F/e8= =/GCE -----END PGP SIGNATURE----- --JbKQpFqZXJ2T76Sg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051201172757.GG20961>