Date: Sun, 04 Jun 2000 19:41:58 -0700 From: Mike Smith <msmith@freebsd.org> To: Josef Karthauser <joe@pavilion.net> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls extern.h ls.1 ls.c ls.h print.c Message-ID: <200006050241.TAA14945@mass.cdrom.com> In-Reply-To: Your message of "Mon, 05 Jun 2000 03:33:38 BST." <20000605033336.Q620@pavilion.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sun, Jun 04, 2000 at 11:00:28PM +0100, Josef Karthauser wrote: > > > escape sequences into the code. That's just vile and Josef Karthauser > > > really needs to back this out or I can guarantee that somebody is > > > going to do it for him and that's not a good way of doing business; a > > > man should always shoot his own dog. > > The dog's been put out of its misery. Joe - when you go to make a commit, there's this field in the message towards the bottom that says "Reviewed by:". In situations like this, ie. when you're touching something that people are really sensitive about, it's a Very Good Idea to have someone fairly authoritative on the topic sign off on your changes so you can put their name there. I'll note that Andrey has at least three valid followups on your changes that should have been dealt with before you committed them. In this case, less haste would have meant more speed. -- \\ Give a man a fish, and you feed him for a day. \\ Mike Smith \\ Tell him he should learn how to fish himself, \\ msmith@freebsd.org \\ and he'll hate you for a lifetime. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006050241.TAA14945>