Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 May 2018 09:57:18 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Matthew Macy <mmacy@freebsd.org>
Cc:        Emmanuel Vadot <manu@bidouilliste.com>, owner-src-committers@freebsd.org,  rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r333822 - head/sys/kern
Message-ID:  <201805191657.w4JGvIdr016605@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <CAPrugNrMkem_ZiUbP5ZmAwVb%2BsAzVafm6GGQE__3pqOZGBS-WA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> On Sat, May 19, 2018 at 07:17 Emmanuel Vadot <manu@bidouilliste.com> wrote:
> 
> > On 2018-05-19 15:35, Rodney W. Grimes wrote:
> > > [ Charset UTF-8 unsupported, converting... ]
> > >> Author: mmacy
> > >> Date: Sat May 19 02:15:40 2018
> > >> New Revision: 333822
> > >> URL: https://svnweb.freebsd.org/changeset/base/333822
> > >>
> > >> Log:
> > >>   fix gcc8 unused variable and set but not used variable in unix
> > >> sockets
> > >>   add copyright from lock rewrite while here
> > >>
> > >> Modified:
> > >>   head/sys/kern/uipc_usrreq.c
> > >>
> > >> Modified: head/sys/kern/uipc_usrreq.c
> > >>
> > ==============================================================================
> > >> --- head/sys/kern/uipc_usrreq.c      Sat May 19 00:47:24 2018
> > (r333821)
> > >> +++ head/sys/kern/uipc_usrreq.c      Sat May 19 02:15:40 2018
> > (r333822)
> > >> @@ -4,7 +4,7 @@
> > >>   * Copyright (c) 1982, 1986, 1989, 1991, 1993
> > >>   *  The Regents of the University of California.
> > >>   * Copyright (c) 2004-2009 Robert N. M. Watson
> > >> - * All rights reserved.
> > >
> > > Did you have permission from Robert Watson to remove this?

This issue seems to be getting ignored?  


> > >> + * Copyright (c) 2018 Matthew Macy
> > >>   *
> > >>   * Redistribution and use in source and binary forms, with or without
> > >>   * modification, are permitted provided that the following conditions
> > > ...
> >
> >   That also seems a small patch to add your name in the copyright.
> >
> 
> Uhh... Locking rewrite was a small patch? Really?

I agree with Matt, he has done plenty of work to this code
to justify his copyright claim.

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805191657.w4JGvIdr016605>