Date: Fri, 02 Apr 2010 12:23:02 +0200 From: Alexander Leidinger <netchild@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r206082 - in head: . share/man/man7 share/mk sys/conf Message-ID: <20100402122302.48713ufeslsu6su8@webmail.leidinger.net> In-Reply-To: <alpine.BSF.2.00.1004021054050.72297@fledge.watson.org> References: <201004020655.o326tWax079882@svn.freebsd.org> <alpine.BSF.2.00.1004021054050.72297@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Robert Watson <rwatson@FreeBSD.org> (from Fri, 2 Apr 2010 10:56:22 +0100 (BST)): > > On Fri, 2 Apr 2010, Alexander Leidinger wrote: > >> WITH_CTF can now be specified in src.conf (not recommended, there >> are some problems with static executables), make.conf (would also >> affect ports which do not use GNU make and do not override the >> compile targets) or in the kernel config (via "makeoptions >> WITH_CTF=yes"). >> >> Additional (related) changes: >> - propagate WITH_CTF to module builds >> - do not add -g to the linker flags, it's a noop there anyway >> (at least according to the man page of ld) >> - do not add -g to CFLAGS unconditionally >> we need to have a look if it is really needed (IMO not) or if there >> is a way to add it only when WITH_CTF is used >> >> Note: ctfconvert / ctfmerge lines will not appear in the build output, >> to protect the innocent (those which do not build with WITH_CTF would >> see the shell-test and may think WITH_CTF is used). > > Excellent -- I'm really glad to see this getting sorted out at last. > > I think there's a reasonable argument that we should be compiling > options KDTRACE_HOOKS into GENERIC, and likewise enabling CTF on the > kernel by default in 9.x. Part of the point of DTrace is that it > "just works", and we already compile CDDL modules by default (and > the hooks don't affect the license of the base kernel as far as I'm > aware). Any thoughts on this? I'm in favour of this. You just need to commit 2 lines for GENERIC (and one for NOTES, I think)... Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 BOFH excuse #36: dynamic software linking table corrupted
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100402122302.48713ufeslsu6su8>