Date: Thu, 14 Jul 2016 06:55:58 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Robert Watson <rwatson@freebsd.org> Cc: Garrett Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r302577 - head/sys/dev/drm2 Message-ID: <095A682C-C8C0-4BAF-947C-A74A250EB2F6@gmail.com> In-Reply-To: <CAGHfRMC8c_okqZSiuM-_DEHMU4B6-oun_K0Dz=epjA0YG1EmtA@mail.gmail.com> References: <201607111701.u6BH189R083052@repo.freebsd.org> <alpine.BSF.2.20.1607131252340.36917@fledge.watson.org> <CAGHfRMC8c_okqZSiuM-_DEHMU4B6-oun_K0Dz=epjA0YG1EmtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jul 13, 2016, at 16:56, Ngie Cooper <yaneurabeya@gmail.com> wrote: > > On Wed, Jul 13, 2016 at 4:54 AM, Robert Watson <rwatson@freebsd.org> wrote: >> On Mon, 11 Jul 2016, Garrett Cooper wrote: >> >>> Add missing default case to capable(..) function definition >>> >>> By definition (enum __drm_capabilities), cases other than CAP_SYS_ADMIN >>> aren't possible. Add in a KASSERT safety belt and return false in >>> !INVARIANTS case if an invalid value is passed in, as it would be a >>> programmer error. >>> >>> This fixes a -Wreturn-type error with gcc 5.3.0. >>> >>> Differential Revision: https://reviews.freebsd.org/D7188 >>> MFC after: 1 week >>> Reported by: devel/amd64-gcc (5.3.0) >>> Reviewed by: dumbbell >>> Sponsored by: EMC / Isilon Storage Division >> >> Per my comment in the review, I think a panic() here would be preferable to >> a KASSERT(), as it would come without perceptible runtime cost, and failstop >> the system if we were violating a design-time security invariant. > > Good point. I'll commit the change tonight. Fixed in r302841. Thanks! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXh5nuAAoJEPWDqSZpMIYVYSgP/12rl0/lQBR6m4+rWiOnAwTF ilYY7fsjP3t1BoHaEHbdfed1OeO7dLajLRxlMO1KHkjZVhPFi+Eu3P/JOG6hU5Qd vNCHEHva2g/EBAUXCLAG2jMW1fW5IUfKxn6sfTAyeFs/+WM/DwnQfdU4OaZ4r5VL PPkvBG+X1l634vm61640OtVBCldB+8nGXMuEvhPbJvMClpI0hVZHv/rZAlYXi3yG +XDxWlCJWsztERHZb5LaGezYlwaUOFSDIRXebq88EdwdYpOTRdR65UUX4ir6BL1G phzOadilojBgN/vkzvCnSHwsDRhlLhrU4PR0gUx9MCHi2rqXnoeYgYGuyv+iN6ZP PkDJ8F+C2smEVMdBK2SQASTKicX+vte5ruxBSQEnDumbnNad4/Y+/g0C5l7gxBmm en3GN4lAYGKDnvL5H0UpP7zgecElnHaMYCwtc0XsiW1r1a6yoBmsRNRyJhazUDia YvB5FdlySqFMSLGAh84+4AKTD8czfybZOKBQb4UdCxkgdToz/vMgiGRNn4DjF+H7 EWLLYgq6VeubMW6zGWtMU5cAW90PhscUAgrWIGftZyVKnsWj3kfk5Oc2qXGJqeUz XXShIrvv7V9Lu1EIk+382sqNamO9cPnuruLPz8m/ZyMiGTvytNlL/y7atZiimTUu W9yINceOT9W/yqkge2La =V5NS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?095A682C-C8C0-4BAF-947C-A74A250EB2F6>