Date: Sun, 15 Dec 2013 17:27:31 -0700 From: Warner Losh <imp@bsdimp.com> To: Howard Su <howard0su@gmail.com> Cc: freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: [PATCH] Add stack unwind support for the functions in .ko Message-ID: <C6E93F79-BA1C-48E9-8689-775D88462921@bsdimp.com> In-Reply-To: <CAAvnz_qmn%2Ba%2B-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ@mail.gmail.com> References: <CAAvnz_pWZqw-HEB-GTJ_CkErjXrz3v7ozabMXE__vr=SfkBVSg@mail.gmail.com> <CAAvnz_p2vw9=HWbGPePKm_yDxM-bM1h6VaQBeJq9sYXPRb2-Lg@mail.gmail.com> <20131215173042.0dead636@bender.Home> <CAAvnz_qmn%2Ba%2B-aE4GkYw6TDOPzfST2j5WGvHqKX4WWVsVACSzQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 15, 2013, at 4:56 PM, Howard Su wrote: > On Monday, December 16, 2013, Andrew Turner wrote: >=20 >> On Mon, 9 Dec 2013 22:44:14 +0800 >> Howard Su <howard0su@gmail.com <javascript:;>> wrote: >>=20 >>> Here is a new version which solve the unreadable $a problem. (the = fix >>> is in ddb/db_main.c in the end of the patch.) >>>=20 >>> I attached the diff for review. >>=20 >> I can't comment on the MD parts of the code, but the ARM change looks >> good. My only request is to add a kernel option to turn on printing = the >> registers in the stack trace as it has been useful for tracking down >> bugs. >>=20 > I read the MD code of MIPS. seems it faces the same situation like arm > (register pass parameter). I will follow its pattern to print out = register. > better than an option? I thought MIPS printed the args from those registers as args and ARM was = the odd man out... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C6E93F79-BA1C-48E9-8689-775D88462921>