Date: Tue, 4 Aug 2015 23:15:23 +0000 (UTC) From: Barney Cordoba <barney_cordoba@yahoo.com> To: hiren panchasara <hiren@freebsd.org>, Eric Joyner <erj@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Subject: Re: Exposing full 32bit RSS hash from card for ixgbe(4) Message-ID: <150756354.750462.1438730123217.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <20150715180138.GK8260@strugglingcoder.info> References: <20150715180138.GK8260@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
What's the point of all of this gobbledygook anyway? Seriously, 99% of the world needs a driver that passes packets in the most efficient way, and every time I look at igb and ixgbe it has another 2 heads. It's up to 8 heads, and none of the things wrong with it have been fixed. This is now even uglier than Kip Macy's cxgb abortion.
I'm not trying to be snarky here. I wrote a simple driver 3 years ago that runs and runs and uses little cpu; maybe 8% for a full gig load on an E3. What is the benefit of implementing all of these stupid offload and RSS hashes? Spreading across cpus is incredibly inefficient; running 8 'queues' on a quad core cpu with hyperthreading is incredibly stupid. 1 cpu can easily handle a full gig, so why are you dirtying the code with 8000 "features" when it runs just fine without any of them? you're subjecting 1000s of users to constant instability (and fear in upgrading at all) for what amounts to a college science project. I know you haven't benchmarked it, so why are you doing it? hell, you added that buf_ring stuff without even making any determination that it was beneficial to use it, just because it was there.
You're trying to steal a handful of cycles with these hokey features, and then you're losing buckets of cycles (maybe wheelbarrows) by unnecessarily spreading the processes across too many cpus. It just makes no sense at all.
If you want to play, that's fine. But there should be simple I/O drivers for em, igb and ixgbe available as alternatives for the 99% of users who just want to run a router, a bridge/filter or a web server. Drivers that don't break features A and C when you make a change to Q and Z because you can't possibly test all 8000 features every time you do something.
Im horrified that some poor schlub with a 1 gig webserver is losing half of his cpu power because of the ridiculous defaults in the igb driver.
On Wednesday, July 15, 2015 2:01 PM, hiren panchasara <hiren@freebsd.org> wrote:
On 07/14/15 at 02:18P, hiren panchasara wrote:
> On 07/14/15 at 12:38P, Eric Joyner wrote:
> > Sorry for the delay; it looked fine to me, but I never got back to you.
> >
> > - Eric
> >
> > On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd <adrian.chadd@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > It's fine by me. Please do it!
>
> Thanks Adrian and Eric. Committed as r285528.
FYI:
I am planning to do a partial mfc of this to stable10. Here is the
patch:
https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash_stable10.patch
(I did the same for igb(4), r282831)
Cheers,
Hiren
From owner-freebsd-net@freebsd.org Tue Aug 4 23:32:19 2015
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A7249B3D4C
for <freebsd-net@mailman.ysv.freebsd.org>;
Tue, 4 Aug 2015 23:32:19 +0000 (UTC)
(envelope-from kob6558@gmail.com)
Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com
[IPv6:2607:f8b0:4003:c01::234])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G2" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 5FF571EA8
for <freebsd-net@freebsd.org>; Tue, 4 Aug 2015 23:32:19 +0000 (UTC)
(envelope-from kob6558@gmail.com)
Received: by obdeg2 with SMTP id eg2so19312078obd.0
for <freebsd-net@freebsd.org>; Tue, 04 Aug 2015 16:32:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=mime-version:sender:in-reply-to:references:date:message-id:subject
:from:to:cc:content-type;
bh=w2dcTrmdpZx3x4tINUliJqU7ULJzNnIt78mbrP5+rBg=;
b=Gtx/VysAb74Gc6xYjsyswJsZyzxiNcjaoPJA1KcBJ1GJYTd6tYiUAe/NjzdRQARgwW
CXIgD/PWSbcCaEUiXtO//xW4coad39lfD6GP56sLKbfjtUyzUL58Fy6LXrKhPC82ByQE
g5fCI9UEcA1m9sCHHsJIswcI6nGqVMEmkpQNiDAh9B/OWgQ56lNRUcBBconKpqCVciY4
h+7TVyrMmvjR3CT5+Jki4hUDUuHp8NCnlDGhLGJK7yjQSjfaAIOZCNXzQndduHo0SKdk
TCnpU76El/bN0LPNBUUN6xT5N/udbaeIOAaQdo8INUxO8R8EaAzlOvztQ0Em/DmIqKwT
t21Q==
MIME-Version: 1.0
X-Received: by 10.60.58.225 with SMTP id u1mr5436603oeq.75.1438731138745; Tue,
04 Aug 2015 16:32:18 -0700 (PDT)
Sender: kob6558@gmail.com
Received: by 10.202.221.69 with HTTP; Tue, 4 Aug 2015 16:32:18 -0700 (PDT)
In-Reply-To: <55C14723.8010601@swin.edu.au>
References: <55C14723.8010601@swin.edu.au>
Date: Tue, 4 Aug 2015 16:32:18 -0700
X-Google-Sender-Auth: oC_7xSISqJ3lzJ5MtVxkEX8rNCs
Message-ID: <CAN6yY1ty3ex4o0JumYqKjvRjobUXUGxhdU=rvViiJ_zrMARZWw@mail.gmail.com>
Subject: Re: bugzilla chatter?
From: Kevin Oberman <rkoberman@gmail.com>
To: grenville armitage <garmitage@swin.edu.au>
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.20
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>;
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2015 23:32:19 -0000
On Tue, Aug 4, 2015 at 4:13 PM, grenville armitage <garmitage@swin.edu.au>
wrote:
>
> <de-lurk>
>
> I'm curious about the uptick of bugzilla chatter turning up in freebsd-net@
> the last few days.
>
> Whilst I can filter it locally, I'm puzzled as to why it would be a Good
> Thing for bugzilla bugs to be "Assigned to" freebsd-net.
>
> cheers,
> gja
>
> <lurk>
>
Yes, Sean has been VERY busy this week in cleaning up old Intel driver (em,
igb, ixgb, etc) tickets.
I, for one, have no problem with seeing them. They are easy for those who
would prefer not to see them and provide a fair bit up useful information
and a reasonable "heads-up" for problem status.
I suspect that once Sean has hit most of the old (some really old) tickets,
things will quiet down a fair bit. (But I could be wrong.) I love seeing
tickets being taken care of.
--
Kevin Oberman, Network Engineer, Retired
E-mail: rkoberman@gmail.com
PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?150756354.750462.1438730123217.JavaMail.yahoo>