Date: Wed, 1 May 1996 16:40:21 PDT From: Bill Fenner <fenner@parc.xerox.com> To: Poul-Henning Kamp <phk@critter.tfs.com> Cc: current@freebsd.org (FreeBSD-current) Subject: Re: local router<->router UDP traffic: log_in_vain stuff error Message-ID: <96May1.164024pdt.177475@crevenia.parc.xerox.com> In-Reply-To: Your message of "Sat, 27 Apr 1996 02:57:05 PDT." <2748.830599025@critter.tfs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <2748.830599025@critter.tfs.com>you write: >> It was RIP packets from my service provider which cause >> local router to router UDP traffic. It seems that kernel >> treats remote UDP traffic as local when udp.log_in_vain used. > >Uhm this doesn't make any sense to me, the log_in_vain change was the >addition of this bit of code: > > if (log_in_vain) > log(LOG_INFO, "Connection attempt to UDP %s:%d" > " from %s:%d\n", > inet_ntoa(ip->ip_dst), ntohs(uh->uh_dport), > inet_ntoa(ip->ip_src), ntohs(uh->uh_sport)); Someone (I don't remember who, perhaps pst) pointed out shortly after this was committed that inet_ntoa() uses a static buffer so this will just log the same address twice. At least, I didn't point it out because I thought someone else had. Bill
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96May1.164024pdt.177475>