Date: Thu, 4 Mar 2004 22:53:05 -0600 From: Alan Cox <alc@cs.rice.edu> To: Robert Watson <rwatson@freebsd.org> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: bug in vm_contig.c? [was: Re: ACPI crash with recent changes] Message-ID: <20040305045305.GA21071@cs.rice.edu> In-Reply-To: <Pine.NEB.3.96L.1040304232746.56322C-100000@fledge.watson.org> References: <4047F3F8.1080207@imimic.com> <Pine.NEB.3.96L.1040304232746.56322C-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 04, 2004 at 11:28:04PM -0500, Robert Watson wrote: > > On Thu, 4 Mar 2004, Alan L. Cox wrote: > > > Please test the attached patch instead. In order to avoid a race > > condition, it is necessary for the loop to begin with "start" rather > > than "start + 1". What is both unnecessary and wrong is the physical > > contiguity check. (My bad. :-() In other words, the test that the page > > is still free must be repeated because of the dropping of the free page > > queue lock, but contiguity once true is always true. > > Using this patch, my testbox boots just fine. > Thanks. I've committed the patch. Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040305045305.GA21071>