Date: Sat, 13 Apr 2019 04:55:30 +0900 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346160 - head/usr.bin/mandoc Message-ID: <CAKBkRUz-68KYew2-i4nJrjBiUG0j3jiOQu3tZ1u4XrQekLbx5w@mail.gmail.com> In-Reply-To: <5DF1F115-692D-48B7-A52C-AD1BF5E738E5@gmail.com> References: <201904121835.x3CIZETP017600@repo.freebsd.org> <5DF1F115-692D-48B7-A52C-AD1BF5E738E5@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 13, 2019 at 3:53 AM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu <lwhsu@FreeBSD.org> wrote: > > > > Author: lwhsu > > Date: Fri Apr 12 18:35:14 2019 > > New Revision: 346160 > > URL: https://svnweb.freebsd.org/changeset/base/346160 > > > > Log: > > Suppress old gcc warning about null format string > > > > This is workaround to make head build on gcc using architectures > > > > Sponsored by: The FreeBSD Foundation > > MFC-with: r346149 > > > > Modified: > > head/usr.bin/mandoc/Makefile > > > > Modified: head/usr.bin/mandoc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/usr.bin/mandoc/Makefile Fri Apr 12 18:13:57 2019 (= r346159) > > +++ head/usr.bin/mandoc/Makefile Fri Apr 12 18:35:14 2019 (= r346160) > > @@ -97,6 +97,8 @@ SRCS=3D ${LIB_SRCS} \ > > WARNS?=3D 3 > > CFLAGS+=3D -DHAVE_CONFIG_H \ > > -I${SRCTOP}/lib/libopenbsd/ > > +# This can be removed after swtiching to newer gcc > > +CFLAGS.gcc+=3D -Wno-format > > LIBADD=3D openbsd z > > > > .include <bsd.prog.mk> > > Couldn=E2=80=99t this be fixed upstream and pulled back in, inste= ad of ignoring the warning? That's possible, but I don't know how much of the possibility that upstream is willing to fix a warning that only occurs in old versions of gcc, and it looks a false positive to me. I am here to put a band-aid first. Best, Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUz-68KYew2-i4nJrjBiUG0j3jiOQu3tZ1u4XrQekLbx5w>