Date: Sat, 13 Mar 2010 13:13:51 -0800 From: Garrett Cooper <yanefbsd@gmail.com> To: Bruce Cran <brucec@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205118 - head/sbin/sysctl Message-ID: <7d6fde3d1003131313l3559b6dbt1566fb23be150408@mail.gmail.com> In-Reply-To: <201003131108.o2DB8vmu001454@svn.freebsd.org> References: <201003131108.o2DB8vmu001454@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 13, 2010 at 3:08 AM, Bruce Cran <brucec@freebsd.org> wrote: > Author: brucec > Date: Sat Mar 13 11:08:57 2010 > New Revision: 205118 > URL: http://svn.freebsd.org/changeset/base/205118 > > Log: > Free the memory allocated via strdup. > > PR: bin/113881 > Submitted by: Alexander Drozdov dzal_mail mtu-net.ru > Approved by: rrs (mentor) > MFC after: 1 week > > Modified: > head/sbin/sysctl/sysctl.c > > Modified: head/sbin/sysctl/sysctl.c > ============================================================================== > --- head/sbin/sysctl/sysctl.c Sat Mar 13 11:06:47 2010 (r205117) > +++ head/sbin/sysctl/sysctl.c Sat Mar 13 11:08:57 2010 (r205118) > @@ -382,6 +382,7 @@ S_timeval(int l2, void *p) > if (*p2 == '\n') > *p2 = '\0'; > fputs(p1, stdout); > + free(p1); > return (0); > } strdup(3) can fail in that section of code, thus the fputs(3) could segfault: [gcooper@bayonetta ~]$ cat foo.c #include <string.h> #include <stdio.h> int main(void) { char *foo = NULL; fputs(foo, stdout); free(foo); return 0; } [gcooper@bayonetta ~]$ gcc -o foo foo.c [gcooper@bayonetta ~]$ ./foo Segmentation fault: 11 (core dumped) Could a... if (p1 == NULL) ... be added before the fputs(3) please? Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1003131313l3559b6dbt1566fb23be150408>