Date: Wed, 12 Aug 2015 22:58:47 -0600 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: Julian Elischer <julian@freebsd.org>, Warner Losh <imp@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286687 - head Message-ID: <D15F3BFE-36F8-4837-90C7-17FB86572B73@bsdimp.com> In-Reply-To: <7AE78D6D-DE39-4C0F-A2AC-4778F4E304A8@gmail.com> References: <201508121900.t7CJ0mhT080491@repo.freebsd.org> <55CC2114.4080904@freebsd.org> <7AE78D6D-DE39-4C0F-A2AC-4778F4E304A8@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Aug 12, 2015, at 10:52 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote: > > On Aug 12, 2015, at 21:46, Julian Elischer <julian@freebsd.org> wrote: > >> On 8/13/15 3:00 AM, Warner Losh wrote: >>> Author: imp >>> Date: Wed Aug 12 19:00:47 2015 >>> New Revision: 286687 >>> URL: https://svnweb.freebsd.org/changeset/base/286687 >>> >>> Log: >>> Document build-tools better. Add rescue back because it builds /bin/sh >>> which has a build-tools target (see commit for how build-tools and >>> cross-tools differ). >> really? do we build ALL of rescue? that contains most of /bin and lots of /usr/bin. > > build-tools only builds /bin/sh and bin/tcsh : > > $ grep BUILDTOOLS rescue/rescue/Makefile > CRUNCH_BUILDTOOLS+= bin/sh > CRUNCH_BUILDTOOLS+= bin/csh > >> that's a lot.. Can we not just build/bin/sh itself? > > That would.. probably make more sense (especially in a post-projects/bmake world)… but it needs better comments in Makefile.inc1 . Actually, what we have is totally fine. There’s nothing to see here. This is now commented adequately in Makefile.inc1, and listing things in Makefile.inc1 is totally wrong other than rescue/rescue because rescue builds things with a different MAKEOBJDIRPREFIX. Rather than have a plethora of ‘reach overs’ to get the built build-tools, and create the crazy build dependencies, we waste < 2s of your time. If somebody wants to convert rescue.mk and bsd.crunchgen.mk to something more meta-mode friendly, that might be interesting, but it’s independent of Makefile.inc1 (mostly because that’s unused in Meta mode). Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVzCQHAAoJEGwc0Sh9sBEApMoQAK3X49rd6NO2tiwDCrLlWkS6 XpEIRo9Z9ng89LMYPEM4marweTc+z+CFpiBjMREbUtLfFUHI83THaCnfou7eAhff L9u8rw9IxtiZNcIgD70MuIWEsPLRmq6OD5io7a4GHyZqh5g4LA0gv78ihkpUtDfJ YNDKQmqHoDE9rm/a+p6wI5R7lVvWi5kpO7IJQWY6LJ43UcTdSJVFBYSIOaHMneH3 x9FydYfCMB9WY02ZdBmoql3ZcJ2Pw0NeTfY2/9jLqRCOo7H3iEMVCGFjvpBDYGGg BOqQ/2+ud5pH3mgW5/zlu96k0Va6lBuaFI5reBF6/xG17+o7qt3UQ9e9sotPl/Yj uTdoBuRKfQGItdRG62IY9GnrbQKaxIOeMPAdEaffKSK/15XhiR7MS5KDnaxrDJx+ GTRQGZBjnPYYkejnS97Hnj3jc8SQXX4GGfo0BhFUf52iI+AdRKaBRKPP0mJrEFmy UGzN9W1smzT4LwEP2A1Jp2mvk40KM63FiN90I9EouohW/WxONxAR+AUgoZvdFscB niN5oJyrSI0SPaPM8QfYw44+G45fvIZFcPLquFxs253LxzLd5aEpUILQQxp7vvVa 1fg+dUONdbJtlZqJYVIgCShHRy4maQ+vAqALGaJwnwRMVDxVzUU4cpa6Omg7sW4D i1GIh0NkUjEtLin6HdiX =BTXH -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D15F3BFE-36F8-4837-90C7-17FB86572B73>