Date: Fri, 12 Apr 2002 13:27:21 -0700 From: David O'Brien <obrien@FreeBSD.ORG> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/emulators/wine Makefile distinfo pkg-plist Message-ID: <20020412132721.A66608@hub.freebsd.org> In-Reply-To: <200204121950.g3CJo0O21945@vega.vega.com>; from sobomax@FreeBSD.org on Fri, Apr 12, 2002 at 10:49:59PM %2B0300 References: <Pine.BSF.4.44.0204121924150.56165-100000@naos.dbai.tuwien.ac.at> <200204121950.g3CJo0O21945@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 12, 2002 at 10:49:59PM +0300, Maxim Sobolev wrote:
> > > Reviewed by: ???
> > > Approved by: ???
> >
> > I have been the maintainer of this port since 2000/05/18.
> >
> > And while David O'Brien (my mentor here) kindly has been and will be
> > reviewing my patches to all other parts of FreeBSD, do I really need
> > to have my changes to this port reviewed/approved by others now, after
> > having submitted/reviewed/approved more than two dozen changes as
> > maintainer of this port???
>
> Yes, you need. This is normal part of your "mentored" period. You
> mentor should have told you that.
Uh... Why does he need it for a port he has maintained for that long?
When I have committed his Wine patches (or any approved by him), I did
not look at them at all. I just:
patch < foo
make
cvs ci
I agree with your statement about things outside of ports/emulators/wine.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020412132721.A66608>