Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 Jun 2016 19:38:19 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 210707] freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious condition
Message-ID:  <bug-210707-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210707

            Bug ID: 210707
           Summary: freebsd/sys/dev/aacraid/aacraid.c: 2 * Suspicious
                    condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

1.

freebsd/sys/dev/aacraid/aacraid.c:2854]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error =3D copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t)) !=3D 0))
        goto out;

Maybe better code

    if ((error =3D copyin((void *)&user_srb->data_len, &fibsize,
        sizeof (u_int32_t))) !=3D 0)
        goto out;

2.

freebsd/sys/dev/aacraid/aacraid.c:2861]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

    if ((error =3D copyin((void *)user_srb, srbcmd, fibsize) !=3D 0))

Maybe better code

    if ((error =3D copyin((void *)user_srb, srbcmd, fibsize)) !=3D 0)

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210707-8>