Date: Fri, 17 Apr 2026 00:21:51 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 688e289ee904 - main - ifconfig: Add support for geneve (netlink) Message-ID: <C3BCD4D1-BC77-4B05-A4D1-701FC9A14598@FreeBSD.org> In-Reply-To: <69dcfad9.46b23.7e93103@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 13 Apr 2026, at 16:16, Pouria Mousavizadeh Tehrani wrote: > The branch main has been updated by pouria: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=688e289ee904fe625d92f93680a71753d03ba2ee > > commit 688e289ee904fe625d92f93680a71753d03ba2ee > Author: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org> > AuthorDate: 2026-04-11 18:38:41 +0000 > Commit: Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org> > CommitDate: 2026-04-13 14:15:01 +0000 > > ifconfig: Add support for geneve (netlink) > > This implementation is netlink only > > Differential Revision: https://reviews.freebsd.org/D55184 This fails to build if WITHOUT_NETLINK_SUPPORT=yes is set. I think we need this: diff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile index cc518693c2f5..26391023d54a 100644 --- a/sbin/ifconfig/Makefile +++ b/sbin/ifconfig/Makefile @@ -30,7 +30,6 @@ SRCS+= ifmedia.c # SIOC[GS]IFMEDIA support SRCS+= iffib.c # non-default FIB support SRCS+= ifvlan.c # SIOC[GS]ETVLAN support SRCS+= ifvxlan.c # VXLAN support -SRCS+= ifgeneve.c # GENEVE support SRCS+= ifgre.c # GRE keys etc SRCS+= ifgif.c # GIF reversed header workaround SRCS+= ifipsec.c # IPsec VTI @@ -67,6 +66,7 @@ LIBADD+= nv .if ${MK_NETLINK_SUPPORT} != "no" SRCS+= ifconfig_netlink.c +SRCS+= ifgeneve.c # GENEVE support .else CFLAGS+=-DWITHOUT_NETLINK .endif Best regards, Kristof [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;"> <p dir="auto">On 13 Apr 2026, at 16:16, Pouria Mousavizadeh Tehrani wrote:</p> <blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;"> <p dir="auto">The branch main has been updated by pouria:</p> <p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=688e289ee904fe625d92f93680a71753d03ba2ee">https://cgit.FreeBSD.org/src/commit/?id=688e289ee904fe625d92f93680a71753d03ba2ee</a></p>; <p dir="auto">commit 688e289ee904fe625d92f93680a71753d03ba2ee<br> Author: Pouria Mousavizadeh Tehrani <a href="mailto:pouria@FreeBSD.org">pouria@FreeBSD.org</a><br> AuthorDate: 2026-04-11 18:38:41 +0000<br> Commit: Pouria Mousavizadeh Tehrani <a href="mailto:pouria@FreeBSD.org">pouria@FreeBSD.org</a><br> CommitDate: 2026-04-13 14:15:01 +0000</p> <pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">ifconfig: Add support for geneve (netlink) This implementation is netlink only Differential Revision: https://reviews.freebsd.org/D55184 </code></pre> </blockquote> <p dir="auto">This fails to build if WITHOUT_NETLINK_SUPPORT=yes is set.</p> <p dir="auto">I think we need this:</p> <pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">diff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile index cc518693c2f5..26391023d54a 100644 --- a/sbin/ifconfig/Makefile +++ b/sbin/ifconfig/Makefile @@ -30,7 +30,6 @@ SRCS+= ifmedia.c # SIOC[GS]IFMEDIA support SRCS+= iffib.c # non-default FIB support SRCS+= ifvlan.c # SIOC[GS]ETVLAN support SRCS+= ifvxlan.c # VXLAN support -SRCS+= ifgeneve.c # GENEVE support SRCS+= ifgre.c # GRE keys etc SRCS+= ifgif.c # GIF reversed header workaround SRCS+= ifipsec.c # IPsec VTI @@ -67,6 +66,7 @@ LIBADD+= nv .if ${MK_NETLINK_SUPPORT} != "no" SRCS+= ifconfig_netlink.c +SRCS+= ifgeneve.c # GENEVE support .else CFLAGS+=-DWITHOUT_NETLINK .endif </code></pre> <p dir="auto">Best regards,<br> Kristof</p> </div> </div> </body> </html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C3BCD4D1-BC77-4B05-A4D1-701FC9A14598>