Date: Thu, 4 Jul 2013 22:41:12 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r252435 - in head/sys/ufs: ffs ufs Message-ID: <20130704204112.GC1402@garage.freebsd.pl> In-Reply-To: <201307010300.r6130GWT035496@svn.freebsd.org> References: <201307010300.r6130GWT035496@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jul 01, 2013 at 03:00:16AM +0000, Pedro F. Giffuni wrote: > Author: pfg > Date: Mon Jul 1 03:00:15 2013 > New Revision: 252435 > URL: http://svnweb.freebsd.org/changeset/base/252435 > > Log: > Change i_gen in UFS to an unsigned type. > > In UFS, i_gen is a random generated value and there is not way for > it to be negative. Actually, the value of i_gen is just used to > match bit patterns and it is of not consequence if the values are > signed or not. > > Following other filesystems, set it to unsigned and use it as such, > > Discussed by: mckusick > Reviewed by: mckusick (previous version) > MFC after: 4 weeks [...] > printf("ufs_extattr_get (%s): inode number inconsistency (%d, %jd)\n", > - mp->mnt_stat.f_mntonname, ueh.ueh_i_gen, (intmax_t)ip->i_gen); > + mp->mnt_stat.f_mntonname, ueh.ueh_i_gen, (uintmax_t)ip->i_gen); For uintmax_t you also need to change %jd to %ju. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iEYEARECAAYFAlHV3egACgkQForvXbEpPzRYMQCfZmA25OrItS3NSYXcgxvcm/9A EnwAoJZmG8gYdirggMhTxjVEPSdDuPLi =5qT9 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130704204112.GC1402>