Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Oct 2010 10:05:13 +0300
From:      Mikolaj Golub <to.my.trociny@gmail.com>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        freebsd-fs@freebsd.org
Subject:   Re: hastd: assertion (res->hr_event != NULL) fails in secondary on split-brain
Message-ID:  <86tyl1m85y.fsf@zhuzha.ua1>
In-Reply-To: <20101004213647.GK7322@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Mon, 4 Oct 2010 23:36:47 %2B0200")
References:  <86hbh44wgl.fsf@kopusha.home.net> <86aamw4l42.fsf@kopusha.home.net> <20101004213647.GK7322@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help

On Mon, 4 Oct 2010 23:36:47 +0200 Pawel Jakub Dawidek wrote:

 PJD> I see three problems:)

 PJD> 1. In child_kill() you interpret status value always, even if it is
 PJD>    invalid due to earlier errors.
 PJD> 2. While copying the code you changed style. Don't you like style(9)?:)

Me like :-). But it looks like my emacs don't. Need to teach it somehow...

 PJD> 3. The patch doesn't fix the root cause of the problem.

Thank you for your comments.

-- 
Mikolaj Golub



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tyl1m85y.fsf>