Date: Mon, 3 Nov 2003 10:55:52 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Hidetoshi Shimokawa <simokawa@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire if_fwe.c Message-ID: <20031103185552.GC31067@Odin.AC.HMC.Edu> In-Reply-To: <200311031301.hA3D1Nuu035458@repoman.freebsd.org> References: <200311031301.hA3D1Nuu035458@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Nov 03, 2003 at 05:01:23AM -0800, Hidetoshi Shimokawa wrote: > simokawa 2003/11/03 05:01:23 PST > > FreeBSD src repository > > Modified files: > sys/dev/firewire if_fwe.c > Log: > - Change driver name to fix if_xname breakage in the previous revision. Sorry about that. > - Don't call device_get_unit() twice. A better solution would be to move the printf below the if_initname call and use if_printf(). I dislike printfs that start with things like "if_fwe%d: ". -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE/pqS2XY6L6fI4GtQRAsqsAJ9kIyf27ZJ88F5z95XC4IWx5qoSZACdHiDB j6wA0/PmEvJt5QXIvYYJvHo= =WL03 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031103185552.GC31067>