Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Mar 2001 12:27:28 -0800 (PST)
From:      Archie Cobbs <archie@dellroad.org>
To:        John Baldwin <jhb@FreeBSD.ORG>
Cc:        arch@FreeBSD.ORG
Subject:   Re: Critical Regions Round II
Message-ID:  <200103232027.f2NKRS928064@arch20m.dellroad.org>
In-Reply-To: <XFMail.010322145353.jhb@FreeBSD.org> "from John Baldwin at Mar 22, 2001 02:53:53 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin writes:
> Also, this entire API was forced out into MI code.  After the discussion on
> the mailing list I propose the following that will hopefully make everyone
> happy:
> 
> disable_intr()  - x86 / ia64 only, just clears the IF or psr.i bit, and is
>                   a MD function
> enable_intr()   - x86 / ia64 only, just sets the IF or psr.i bit, and is a
>                   MD function

Apologies in advance if I'm missing something obvious..

Shouldn't these be, e.g.,

  i386_disable_intr(), i386_enable_intr()

    and

  ia64_enable_intr(), ia64_disable_intr()

That is, it seems like "machine dependent" has a strict meaning,
it means: specific to a single (one) architecture.

Or are we expecting to have code that looks like this:

    #if defined(__i386__) || defined(__ia64__)
	    disable_intr()
    #endif

??

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103232027.f2NKRS928064>