Date: Mon, 30 Dec 2002 10:49:05 +0100 From: phk@FreeBSD.org To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys _mutex.h Message-ID: <3507.1041241745@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 30 Dec 2002 14:58:30 %2B1100." <20021230142740.R44529-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20021230142740.R44529-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 29 Dec 2002, Poul-Henning Kamp wrote: > >> phk 2002/12/29 03:14:41 PST >> >> Modified files: >> sys/sys _mutex.h >> Log: >> Save 16 bytes per mutex if MUTEX_PROFILING is not defined. >> >> MUTEX_PROFILING is in opt_global.h, so this does not introduce a risk of >> variant structure sizes unless foreign kernel modules are used. > >Not so. This breaks all modules, not just foreign ones, since >opt_global.h is not included in any module, and even if it were then >its setting for some modules might differ from the setting in the >kernel. Ok, we should make MUTEX_PROFILING an undocumented option then. A cost of 16 bytes per mutex is not warranted for a "only once in a blue moon" option. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3507.1041241745>