Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Apr 2026 21:08:50 +0000
From:      Bjoern A. Zeeb <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: d81388696014 - stable/15 - rtw89: add a warn about beacon_int or dtim_period being 0
Message-ID:  <69e938e2.303bd.2bda0977@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=d81388696014dbfe21e434e1b660152bbbb41b35

commit d81388696014dbfe21e434e1b660152bbbb41b35
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2026-04-17 02:40:03 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2026-04-22 20:57:07 +0000

    rtw89: add a warn about beacon_int or dtim_period being 0
    
    While after the changes to LinuxKPI 802.11 we should never be assoc
    and not have dtim_period set, we have seen before that this could
    happen.  Add a WARN as that will help debugging the following DIV 0.
    
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit 99bbfb77e3c395805fe0a7f19006c5c29136f9fc)
---
 sys/contrib/dev/rtw89/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sys/contrib/dev/rtw89/core.c b/sys/contrib/dev/rtw89/core.c
index aeaf1c8f80c5..1dee73a62f98 100644
--- a/sys/contrib/dev/rtw89/core.c
+++ b/sys/contrib/dev/rtw89/core.c
@@ -2838,6 +2838,10 @@ static void rtw89_core_bcn_track_assoc(struct rtw89_dev *rtwdev,
 	dtim = bss_conf->dtim_period;
 	rcu_read_unlock();
 
+#if defined(__FreeBSD__)
+	WARN(beacon_int == 0 || dtim == 0, "period %u / beacon_int %u / dtim %u\n",
+	    period, beacon_int, dtim);
+#endif
 	beacons_in_period = period / beacon_int / dtim;
 	bcn_intvl_us = ieee80211_tu_to_usec(beacon_int);
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69e938e2.303bd.2bda0977>