Date: Sun, 29 Sep 2002 23:41:11 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aic7xxx/aicasm aicasm_symbol.c Message-ID: <20020930064111.GA1082@dragon.nuxi.com> In-Reply-To: <20020930155132.O44572-100000@gamplex.bde.org> References: <200209300247.g8U2lNAA078034@freefall.freebsd.org> <20020930155132.O44572-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 30, 2002 at 04:12:58PM +1000, Bruce Evans wrote: > On Sun, 29 Sep 2002, David E. O'Brien wrote: > > > obrien 2002/09/29 19:47:23 PDT > > > > Modified files: > > sys/dev/aic7xxx/aicasm aicasm_symbol.c > > Log: > > Use fcntl.h from inside /sys. > > > > Reviewd by: scottl > > > > Revision Changes Path > > 1.21 +1 -1 src/sys/dev/aic7xxx/aicasm/aicasm_symbol.c > > This is sort of backwards. aicasm runs on the host, so it should > include only host headers. Howver, the change should be only a style > bug in practice, since fcntl.h is a link to sys/fcntl.h and there > shouldn't be any -I paths to /sys in the build of aicasm. There > seems to be a problem only with the <machine> directory: there is a > -I path to the kernel build directory and that directory has a > machine symlink in it, so aicasm is built with an inconsistent set > of includes in kernels. Don't know what to say, other than it bit me a few months ago aicasm it was reaching outside of /sys back when the low-down "not to be included directly" headers moved around. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020930064111.GA1082>