Date: Mon, 7 Jul 2014 20:50:25 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Ryan Steinmetz <zi@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Barrie Archer <enquiry@myarcher.net>, perl@freebsd.org, portmgr@freebsd.org Subject: Re: p5-Git-Repository Message-ID: <20140707185025.GC97203@ivaldir.etoilebsd.net> In-Reply-To: <20140707162734.GC74596@exodus.zi0r.com> References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <D6280EB537813A51DA64B820@ogg.in.absolight.net> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> <20140707162734.GC74596@exodus.zi0r.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2014 at 12:27:34PM -0400, Ryan Steinmetz wrote: >=20 > On (07/07/14 18:19), Baptiste Daroussin wrote: > >On Mon, Jul 07, 2014 at 12:13:18PM -0400, Ryan Steinmetz wrote: > >> > >> On (07/07/14 17:55), Mathieu Arnold wrote: > >> >+--On 7 juillet 2014 09:44:09 -0400 Ryan Steinmetz <zi@FreeBSD.org> w= rote: > >> >| We should either add workarounds for older systems or a warning > >> >| that will be printed if a user is running a FreeBSD release that la= cks > >> >| required functionality for the ports tree to function. > >> > > >> >Well, the ports tree is only guaranteed to work with supported FreeBSD > >> >releases. So, if you're not running a supported release, you're on yo= ur own. > >> > > >> >We can't add bits and pieces of version checks around everything that= won't > >> >work with older releases. > >> > >> We know what the supported releases are and we can easily add a check > >> to the framework to verify that you are running a supported release and > >> print a message if not. This would be identical to what was done with > >> the PKGNG checks/warnings. > >> > >> The goal is to give the user a useful message ("You are using an > >> unsupported version, please upgrade.") versus the errors that Barrie r= an > >> into ("Unknown modifier 't'" or "make: fatal errors encountered -- can= not continue"). > > > >Except that is that case it is impossible to catch it reliably, some imp= ossible > >to warn about it. >=20 > We don't need to catch anything. We simply need: >=20 > .if (${OSVERSION} >=3D 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} = >=3D 1000704 > ${ECHO} "You are using an unsupported release. The ports tree may not > function correctly. Please update to a supported release for the best > experience. See http://.....freebsd.org/... for a list of supported > releases. > .endif >=20 > Obviously the versions are not correct, but, again, the goal is to give > people something to work with. Just like what we did with the PKGNG > warnings. >=20 > -r >=20 that won t work because you will have a syntax error before being able to p= rint that Bapt --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlO66/EACgkQ8kTtMUmk6EzT2gCeMuPzVLDURqKj+bfJoZr6D7bU c/sAnjDTP5CMok4FabHhIQN6s1SEor0k =BYBA -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140707185025.GC97203>