Date: Thu, 28 May 2015 15:07:01 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Craig Rodrigues <rodrigc@freebsd.org>, Johannes Jost Meixner <xmj@freebsd.org>, freebsd-current Current <freebsd-current@freebsd.org>, "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: Need help reducing compilation warnings in CURRENT Message-ID: <CAGHfRMDpvpa0AnCegVDrpcW=3w6P%2Bw-87UpP=8wZeXwQHZ7ccQ@mail.gmail.com> In-Reply-To: <20150528191806.GB70327@ivaldir.etoilebsd.net> References: <CAG=rPVdLjmj8oOeqQQOLr6ShvU=2H3y0j5hg4q8UrB70rj3Xpg@mail.gmail.com> <55670C5A.6080500@FreeBSD.org> <CAG=rPVcfs4LB36L8ToOFkVad5t=CWb6wSOog=SfWT-8t-7tDwg@mail.gmail.com> <20150528191806.GB70327@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 28, 2015 at 12:18 PM, Baptiste Daroussin <bapt@freebsd.org> wrote: ... > If not upstreamed, there is a good chance it get lost during the next update. So > in the special case of warning fixes, I would strongly advice to upstream > first!! +200 Plus upstream sources generally get slammed by multiple downstream projects, so if we can contribute back fixes or pull in upstream fixes as cherrypicks through the vendor tree, then that would reduce our diff and make sure that upstream projects benefit from our changes. The only time we should really be modifying and not giving back is when we have FreeBSD-specific modifications that don't make sense in upstream projects. Those should be rare occurrences though... Thanks, -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMDpvpa0AnCegVDrpcW=3w6P%2Bw-87UpP=8wZeXwQHZ7ccQ>