Date: Sun, 28 Jun 2015 12:05:34 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r284912 - head/usr.bin/units Message-ID: <AA256201-43F0-4889-A02C-96B8118E07FC@gmail.com> In-Reply-To: <201506281643.t5SGh7D9009454@svn.freebsd.org> References: <201506281643.t5SGh7D9009454@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 28, 2015, at 09:43, Julio Merino <jmmv@FreeBSD.org> wrote: >=20 > Author: jmmv > Date: Sun Jun 28 16:43:07 2015 > New Revision: 284912 > URL: https://svnweb.freebsd.org/changeset/base/284912 >=20 > Log: > Only initialize libedit when necessary >=20 > The code path to support units conversions from the command line > need not initialize neither libedit nor the history. Therefore, only do > that when in interactive mode. >=20 > This hides the issue reported in PR bin/201167 whereby running commands > of the form 'echo "$(units ft in)"' would corrupt the terminal. The real= > issue causing the corruption most likely still remains somewhere. >=20 > PR: bin/201167 > Differential Revision: D2935 > Reviewed by: eadler Jenkins has been so messed up recently with timeouts and the like that it's h= ard to tell where things went south.. Can you please add your TERM and locale variables to the PR? I suspect that i= t might be a related issue..=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AA256201-43F0-4889-A02C-96B8118E07FC>