Date: Tue, 25 Apr 2006 16:55:51 -0700 (PDT) From: Matthew Jacob <mj@feral.com> To: Warner Losh <imp@bsdimp.com> Cc: cvs-src@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h Message-ID: <20060425165324.M64286@ns1.feral.com> In-Reply-To: <20060425.173236.74726638.imp@bsdimp.com> References: <444E7750.206@samsco.org> <200604251540.00170.jhb@freebsd.org> <444E7BFE.4040800@samsco.org> <20060425.173236.74726638.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> The problem is that PAE's bus_size_t is a 32-bit quantity, when it > should be a 64-bit quantity: > > #ifdef PAE > typedef uint64_t bus_addr_t; > #else > typedef uint32_t bus_addr_t; > #endif > typedef uint32_t bus_size_t; > > For bus addresses, we should use bus_addr_t, of course, but the above > is wrong. I don't have a PAE machine, or I'd commit my local changes > that fix this... > Why do you believe that it should be a 64 bit quantity under PAE? Strictly speaking, I don't believe it is. PAE allows you to *address* 36 physical address bits of memory using Dual Address cycles, but the underlying bus is still a 32 bit bus.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060425165324.M64286>