Date: Sun, 20 May 2007 21:25:42 -0700 (PDT) From: mjacob@freebsd.org To: Bruce Evans <bde@optusnet.com.au> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Matt Jacob <mjacob@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/hptmv ioctl.c Message-ID: <20070520212020.D71516@ns1.feral.com> In-Reply-To: <20070521132204.D86236@besplex.bde.org> References: <200705201649.l4KGnApl032671@repoman.freebsd.org> <20070521132204.D86236@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> mjacob 2007-05-20 16:49:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/hptmv ioctl.c >> Log: >> Make gcc 4.2 happy by initiatlizing controller && channel prior >> to a call to a function which *might* then initialize them. >> >> MFC after: 3 days > > Isn't the bug that the function doesn't always initialize them? > > Bruce > That was a meta-comment- I should have made it clearer. The function get_disk_location *will* always init them, but gcc-4.2 doesn't know that, and unlike previous versions of gcc, gcc-4.2 no longer will assume that a function that you pass a pointer to local data to will actually fill them in. -matt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070520212020.D71516>