Date: Mon, 3 Nov 2003 14:03:46 -0500 From: Alexander Kabaev <ak03@gte.com> To: Alfred Perlstein <bright@mu.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vfsops.c src/sys/ufs/ffs ffs_vfsops.c Message-ID: <20031103140346.54afab43.ak03@gte.com> In-Reply-To: <20031103185522.GE47459@elvis.mu.org> References: <200311030446.hA34kJl5078327@repoman.freebsd.org> <20031103185522.GE47459@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Nov 2003 10:55:22 -0800 Alfred Perlstein <bright@mu.org> wrote: > * Alexander Kabaev <kan@FreeBSD.org> [031102 20:46] wrote: > > kan 2003/11/02 20:46:19 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/gnu/ext2fs ext2_vfsops.c > > sys/ufs/ffs ffs_vfsops.c > > Log: > > Use VOP_UNLOCK/vrele instead of vput. td was erecived as a > > parameter and one cannot be sure it is equal to curthread. > > If there is one place (boot()) where this isn't the case, can't that > place be fixed? My guess is that a lot of other stuff breaks when > the thread vop parameter isn't curthread in other cases. > There is a number of issues with fixing sync to pass a real curthread and Bruce listed them in his email. Going forward, I think we should strip 'td' parameters from VOPs altogether, but I think this is a 6.0 material. -- Alexander Kabaev
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031103140346.54afab43.ak03>