Date: Fri, 20 Aug 2004 03:04:31 +0200 From: Christian Brueffer <chris@unixpages.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: [REVIEW/TEST] Rewritten floppy driver. Message-ID: <20040820010431.GD12219@unixpages.org> In-Reply-To: <2711.1092950127@critter.freebsd.dk> References: <20040819211141.GA12219@unixpages.org> <2711.1092950127@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--RhUH2Ysw6aD5utA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 19, 2004 at 11:15:27PM +0200, Poul-Henning Kamp wrote: > In message <20040819211141.GA12219@unixpages.org>, Christian Brueffer wri= tes: > > > >--k+w/mQv8wyuph6w0 > >Content-Type: text/plain; charset=3Dus-ascii > >Content-Disposition: inline > >Content-Transfer-Encoding: quoted-printable > > > >On Thu, Aug 19, 2004 at 03:43:07PM +0200, Poul-Henning Kamp wrote: > >>=3D20 > >> Please review and test this patch: > >>=3D20 > >> http://phk.freebsd.dk/patch/fdc.patch > >>=3D20 > > > >The patch works for me, except mounting a write protected disk read-only: > > > >haakonia# mount -t msdosfs -r /dev/fd0 /mnt/private/ > >msdosfs: /dev/fd0: Read-only file system >=20 > This is a bug elsewhere and it is fixed on my "phk_bufwork" branch > which will arrive in -current in about a month or so. >=20 I just noticed, that the patch breaks world: cc -O -pipe -g -march=3Dpentium -I/usr/home/build/src/usr.sbin/fdcontrol/../fdread -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c: In function `main': /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: `FD_DEBUG' undeclared (first use in this function) /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: (Each undeclared identifier is reported only once /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: for each function it appears in.) *** Error code 1 Stop in /usr/home/build/src/usr.sbin/fdcontrol. *** Error code 1 Stop in /usr/home/build/src/usr.sbin. *** Error code 1 Stop in /usr/home/build/src. *** Error code 1 Stop in /usr/home/build/src. *** Error code 1 Stop in /usr/home/build/src. haakonia# - Christian --=20 Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D --RhUH2Ysw6aD5utA4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBJU4fbHYXjKDtmC0RAge5AJ9bhkL08MjZE9EWzMZKorEr4PXEIgCggvEq 2JNIu7QNm33XBmM2GaxpSiE= =kLIK -----END PGP SIGNATURE----- --RhUH2Ysw6aD5utA4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040820010431.GD12219>