Date: Mon, 29 Aug 2011 14:03:05 +0100 From: Chris Rees <crees@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Koop Mast <kwm@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/textproc/ots Makefile Message-ID: <CADLo839MkBrHQRz4B4XRTaSEO51uC%2BXsQXnc3OrZjiMf2Bkkvw@mail.gmail.com> In-Reply-To: <20110826200234.GA8743@FreeBSD.org> References: <201108261828.p7QISje3085996@repoman.freebsd.org> <20110826200234.GA8743@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/8/26 Alexey Dokuchaev <danfe@freebsd.org>: > On Fri, Aug 26, 2011 at 06:28:45PM +0000, Koop Mast wrote: >> kwm 2011-08-26 18:28:45 UTC >> >> Modified files: >> textproc/ots Makefile >> Log: >> Mark MAKE_JOBS_UNSAFE. > > Just replying to a random MAKE_JOBS_UNSAFE commit. I have a suggestion > which I think would help us to fix parallel builds when portmgr@ decides to > start running -exp runs with forced MAKE_JOBS: every time one of us marks a > port as MAKE_JOBS_UNSAFE, should provide a short comment on the nature of a > failure. While in majority of cases it can hardly be generalized as it is > probably due to the incorrectly defined dependencies, sometimes it's one > of the well-known cases: missing `-p' switch to mkdir(1) calls, GNU make vs. > BSD make (devel/nasm is an example of this particular case), or if it only > fails for -j4 but not -j2. > > Perhaps MAKE_JOBS_UNSAFE knob could be refactored into something similar to > other "brokenness" knobs and tought to accept a reason string, while "yes" > value could still be used for cases when exact cause of breakage is not so > obvious. > > I also encourage everyone who experience brokenness during parallel builds > check what popular GNU/Linux distros think about it. AFAIK, Gentoo does > parallel builds by default, and explicitly passes -j1 in their ebuilds if > they don't have relevant patch. Sometimes the patch exists, in which case > it should be backported to FreeBSD. Ditto for OpenBSD, Debian, RedHat... > There's no reason a comment can't be put into MAKE_JOBS_UNSAFE; [crees@hydra]~% echo /usr/ports/Mk/* | xargs grep '^[^#].*MAKE_JOBS_UNSAFE' /usr/ports/Mk/bsd.port.mk:.if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE) Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839MkBrHQRz4B4XRTaSEO51uC%2BXsQXnc3OrZjiMf2Bkkvw>