Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Apr 2001 12:52:40 +0200
From:      Martin Cracauer <cracauer@cons.org>
To:        Brian Somers <brian@FreeBSD.ORG>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/bin/sh parser.c
Message-ID:  <20010409125240.A15655@cons.org>
In-Reply-To: <200104041011.f34ABhD62212@freefall.freebsd.org>; from brian@FreeBSD.ORG on Wed, Apr 04, 2001 at 03:11:43AM -0700
References:  <200104041011.f34ABhD62212@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In <200104041011.f34ABhD62212@freefall.freebsd.org>, Brian Somers wrote: 
> brian       2001/04/04 03:11:43 PDT
> 
>   Modified files:
>     bin/sh               parser.c 
>   Log:
>   A much better (more correct) fix for handling ``!'' characters

This is broken for pipes in ! constructs. Try this:

if ! echo bla | wc -c ; then
	echo broken
fi
if ! wc -c /etc/hosts ; then
	echo broken
fi

I am available for reviews of sh fixes.

Martin
-- 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Martin Cracauer <cracauer@cons.org>            http://www.cons.org/cracauer/
 As far as I'm concerned,  if something is so complicated that you can't ex-
 plain it in 10 seconds, then it's probably not worth knowing anyway -Calvin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010409125240.A15655>